You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the stores in memset are invalid for certain arguments due to enforcing a constant offset where we'd instead want the whole offset to wrap around. Traced this back to #1103 where I assumed that we'd be using lowMemoryUnused anyhow (i.e. never storing to the low 1024 bytes of memory), which actually isn't always the case in memset.
Hmm, it seems this cause to significant regression in term of code size and perhaps performance. I prefer solve (fix) this on binaryen side instead just revert all changes
Case store<u8>(-2, 0, 3) possible only if you manually set memory.fill(0, 0, 2). But usually it's not possible in managed runtime when we have memoryBase >= 8. So I guess better add fix to binaryen which normalize store<u8>(-2, 0, 3) to store<u8>(1, 0, 0)
I am not sure that this can be fixed on the Binaryen side, since what we are emitting (store with explicit constant offset) is already invalid for certain, even though uncommon, inputs. I agree that the code size regression here is unfortunate, but at least it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the stores in
memsetare invalid for certain arguments due to enforcing a constant offset where we'd instead want the whole offset to wrap around. Traced this back to #1103 where I assumed that we'd be using lowMemoryUnused anyhow (i.e. never storing to the low 1024 bytes of memory), which actually isn't always the case inmemset.Discovered in #1785.