tests: Add tests for StaticArray#1728
tests: Add tests for StaticArray#1728dcodeIO merged 1 commit intoAssemblyScript:masterfrom saulecabrera:add-tests-for-static-array
Conversation
|
@dcodeIO @MaxGraey one thing that I noticed while working on this is that we have
But There's also |
Adds the following missing tests for StaticArray: - constructor - fromArray - concat (static) - slice (sstatic) - concat (instance) - includes - indexOF - join + toString
|
@dcodeIO 👋 any thoughts on this? |
|
It's a bit unfortunate that |
That's a valid outcome of this discussion, I think that as long as the differences are pointed out correctly then the name becomes less relevant. That said, I didn't intend to make my comment above a blocker to merge this, it was mostly observation. I'll follow up with a documentation issue/PR. |
|
Thanks! :) |
Adds the following missing tests for StaticArray:
constructor
fromArray
concat (static)
slice (static)
concat (instance)
includes
indexOf
join + toString
I've read the contributing guidelines