Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment to reduce overhead of the shadow stack pass. The pass is currently maintaining more stack slots than necessary (anywhere something managed naively goes to the stack) to be sure, but there is room for improvement.
The relatively simple changes in this PR reduce optimized binary size by about 10% and increase throughput by a little less than 10% (testing with the compiler). Optimizations here are risky, though, because any mistake, not only in the shadow stack pass itself but also in compiler code, for instance where an actually necessary (pre-)instrumentation is missing, can lead to unforeseen consequences that only show themselves randomly.
As such it may make sense to test with various programs and various GC configurations first to minimize the risk.