Clear mypy annotation-unchecked notes in tests#41
Merged
Conversation
These 14 test functions carried variable annotations in otherwise-untyped bodies, so mypy skipped their bodies and emitted annotation-unchecked notes. Adding `-> None` return annotations makes mypy type-check the bodies, clearing the notes. Tests stay exempt from requiring return annotations elsewhere; this only annotates the functions that already had body-level annotations. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mypy emitted 18
annotation-uncheckednotes across 9 test files. These fire when an untyped function body contains a variable annotation — mypy skips the body of an untyped function by default and notes that you'd need--check-untyped-defsto check it.The fix adds
-> Nonereturn annotations to the 14 enclosing test functions, which makes mypy treat them as typed and check their bodies. This matches the project convention that tests are exempt from requiring return annotations but are still type-checked.Verification
uv run mypy→Success: no issues found in 142 source files(all notes gone)uv run pyright -p pyrightconfig.tests.json→0 errors, 0 warnings🤖 Generated with Claude Code