Extract shared system-prompt resolver for the two voice commands#173
Merged
Conversation
`agent` and `agent-framework` carried a byte-for-byte identical `_resolve_system_prompt` helper. Move it to `app/agent_shared.py` (the `doctor_checks`/`setup_exec` precedent for run-logic shared between commands) and import it in both `_exec.py` modules, so the persona-file resolution lives in one place.
…pleters `complete_voice` (agent + agent-framework) and `complete_model` (llm) each re-implemented the same `[o for o in options if o.startswith(incomplete)]` filter. Hoist it to `core.choices.complete_prefix` and delegate from all three, so the completion contract lives in one tested place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentandagent-frameworkcarried a byte-for-byte identical_resolve_system_prompthelper. Move it toapp/agent_shared.py(thedoctor_checks/setup_execprecedent for run-logic shared betweencommands) and import it in both
_exec.pymodules, so the persona-fileresolution lives in one place.