Changed the print() in API to log instead.#8
Merged
roks0n merged 2 commits intoArkEcosystem:developfrom Jun 17, 2018
Merged
Conversation
Author
|
The flake8 that ran in CI picked up an import order error that I had to fix and commit. My local flake8 did not complain. Does anyone know why this would happen? |
|
did you install all flake8 libs? https://github.com/ArkEcosystem/python-client/blob/develop/setup.py#L7 |
Author
|
Ah, I didn't know it was a different module. Thanks @mihazelnik |
roks0n
approved these changes
Jun 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the print function in the API sendRequest() to log as an error instead. I don't think it's a good idea for an API to print anything to stdout. That should be left to the application using the API.