-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Feature Request: Option to disable preview (iframe) to original URL #800
Copy link
Copy link
Open
Labels
expected: unlikely unless contributedThis change is unlikely to be made unless someone contributes a PR for review.This change is unlikely to be made unless someone contributes a PR for review.size: mediumstatus: idea-phaseWork is tentatively approved and is being planned / laid out, but is not ready to be implemented yetWork is tentatively approved and is being planned / laid out, but is not ready to be implemented yettouches: API/CLI/Spectouches: configurationwhy: securityIntended to improve ArchiveBox security or data integrityIntended to improve ArchiveBox security or data integrity
Description
Activity
Metadata
Metadata
Assignees
Labels
expected: unlikely unless contributedThis change is unlikely to be made unless someone contributes a PR for review.This change is unlikely to be made unless someone contributes a PR for review.size: mediumstatus: idea-phaseWork is tentatively approved and is being planned / laid out, but is not ready to be implemented yetWork is tentatively approved and is being planned / laid out, but is not ready to be implemented yettouches: API/CLI/Spectouches: configurationwhy: securityIntended to improve ArchiveBox security or data integrityIntended to improve ArchiveBox security or data integrity
Type
What is the problem that your feature request solves
Use iframe to preview original URL may leak
RefererURL, cause JavaScript to be executed on browser and cookie leaved.This may cause some problem related to security and privacy.
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
Have an option to disable iframe preview to orignal URL, and/or option to remove
allow-scriptsfromiframe.sandboxattributeWhat hacks or alternative solutions have you tried to solve the problem?
Remove
iframetag completely from HTML template.Also, I've sent a PR (#799) to resolve the
RefererproblemHow badly do you want this new feature?