Merged
Conversation
…ledException` as an input parameter (Issue #338) * Added overloads to all sync/async timeout syntax classes to allow passing of exception in onTimeout delegates * Added unit tests
Better error messaging when the generic execute/async overloads are used on a non-generic cache policy, and the sync/async usage is not aligned between policy and execute call.
Remove references to deprecated overloads in readme
Add notes on when retry and circuit-breaker rethrow exceptions
To add the error count to the onRetry actions
Eliminates recursive calls which would lead to StackOverflowException. Reduces the number of method-chain hops for certain overloads.
Adds specs on new WaitAnd/RetryForever/Async(...) overloads where the onRetry/Async delegate can take the retryCount as an input parameter.
…-overloads Add new retry forever / wait and retry forever overloads where the `onRetry` delegate can take `retryCount` as an input parameter.
Fix: generic execute method on non-generic CachePolicy should not throw internally when cache holds no value under the given cache key
Minor tidying and consistency in the timeout syntax classes
Minor tidying and consistency in the timeout syntax classes
Rationalise timeout tests for 338 (make the only new tests those which specifically test the new functionality)
Fix Context.PolicyKey such that, as execution bubbles back outwards through a PolicyWrap, Context.PolicyKey correctly adopts the value of the policies in play during the outward journey through the wrap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
onTimeout/asyncdelegates to take the thrownOperationCanceledExceptionas an input parameter #338)Confirm the following