✨ [transaction] SAGA orchestrator support for coordinated multi-step transactions with rollback handling
#762
Conversation
…p transactions with rollback handling
utils/parallelisation/group.go
Outdated
| // CopyFunctions copies the registered functions to group g | ||
| CopyFunctions(g IExecutionGroup[T]) | ||
| Len() int | ||
| // Clone returns a new execution group with all the same functions being registered. |
There was a problem hiding this comment.
Can we provide some context on what happens if a group has already been executed.
Particularly in cases where you have used OnlyOnce as an option.
Should Execute be idempotent across clones? Or should it be like a context?
| ) | ||
|
|
||
| //go:generate go tool mockgen -destination=./mocks/mock_$GOPACKAGE.go -package=mocks io.Closer | ||
| ////go:generate go tool mockgen -destination=./mocks/mock_$GOPACKAGE.go -package=mocks io.Closer |
There was a problem hiding this comment.
mockgen now fails for some reason when it comes to use interfaces from a different package. This is so that we can still run go generate ./...
| } | ||
| } | ||
|
|
||
| func (g *PriorityExecutionGroup[T]) RegisterFunctions(functionSeq iter.Seq[T]) { |
There was a problem hiding this comment.
What is the point of using iterators here?
Iterators are lazy but we will want to evaluate them all at once to register them right?
And it makes it harder to register from scratch because you have to have some function that returns an iterator?
There was a problem hiding this comment.
so this is an addition to the registerFunction(slice) so you don't have to use it.
the purpose of this is so that we can have a more functional API since we can provide something like collection.MapSequence(collection.RangeSequence(),i->func()...).
joshjennings98
left a comment
There was a problem hiding this comment.
Just a few comments but nothing big
Co-authored-by: Josh <josh.jennings@arm.com>
Co-authored-by: Adrien CABARBAYE <adrien.cabarbaye@arm.com>
Description
Test Coverage