Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Fix: condition in tx simulation - #4006

Merged
katspaugh merged 1 commit into
devfrom
fix-sim-cond
Jul 1, 2022
Merged

katspaugh merged 1 commit into
devfrom
fix-sim-cond

Conversation

@katspaugh

Copy link
Copy Markdown
Contributor

Looks like another Boolean logic mistake. Probably after someone asked to refactor it in the PR comments.

Fixes #4003 (comment)

@github-actions

github-actions Bot commented Jul 1, 2022

Copy link
Copy Markdown

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions

github-actions Bot commented Jul 1, 2022

Copy link
Copy Markdown

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions

github-actions Bot commented Jul 1, 2022

Copy link
Copy Markdown

Deployment links

Mainnet     🟣 Polygon     🟠 Rinkeby

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2594858630

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 37.631%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/safe/components/Transactions/helpers/TxModalWrapper/index.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/safe/components/Transactions/helpers/TxModalWrapper/index.tsx 1 57.32%
Totals Coverage Status
Change from base Build 2590128383: 0.0%
Covered Lines: 4104
Relevant Lines: 9904

💛 - Coveralls

@katspaugh katspaugh mentioned this pull request Jul 1, 2022
@francovenica

Copy link
Copy Markdown
Contributor

Looks good, merge it in the RC

@katspaugh
katspaugh merged commit 00aa763 into dev Jul 1, 2022
@katspaugh
katspaugh deleted the fix-sim-cond branch July 1, 2022 12:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants