Bug fixing & housekeeping: because 3ds-rpc deserves it#82
Bug fixing & housekeeping: because 3ds-rpc deserves it#82HotaruBlaze wants to merge 20 commits into3DS-RPC:developmentfrom
Conversation
| # TODO:(Phoenix): Assumes 3s per user (300s for 100 users). May need to increase to 6s/user (10 min per batch) | ||
| # If timeout is exceeded, the batch ends early (may stop mid-batch) to prevent hangs | ||
| timeout = 3 * len(current_rotation) | ||
| with anyio.move_on_after(timeout) as timeout_scope: |
There was a problem hiding this comment.
This timeout applies per batch of 100 users, not the whole loop.
Right now we’re assuming about 3s per user (so 300 s per batch), but it’s hard to be sure that’s enough at this scale.
If timeout_scope triggers often, 3 s per user is likely too short, we may want to increase it to 6 s per user (~10 min per batch) to avoid batches ending early.
|
It might also be worth reviewing all the delays we’re using. I know some are intentional, but we could clean up unnecessary ones or give specific delays clearer, more descriptive names, for example, |
I've gone ahead and done this for backend.py here: #543307e, i havent touched discord.py since that looks like it might need overhauled itself and its hard to test without valid activities.write. |
No description provided.