refactor(installer): add reproducible build sources - #161
Merged
Conversation
Split embedded installer payloads into shared and platform-specific sources, preserve byte-identical generated artifacts, and enforce drift checks in compatibility and release workflows.\n\nSupersedes #108.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shandinstall.ps1reproducibly withnode build.jsnode build.js --checkto compatibility CI and release.gitattributesThe generated installers are byte-for-byte identical to current
main; this PR does not change installation behavior.Source layout
src/shared/: extractor, post-processor, repatcher, proxy, universal patcher, featuressrc/unix/andsrc/windows/: genuinely platform-specific payloadssrc/templates/: installer shell with explicit placeholdersUnlike the stale sources in #108, the universal patcher and other identical payloads have one shared source of truth.
Validation
node build.js --checknode --checkfor every embedded JS payloadbash -n install.shactionlintfor compat and release workflowsSupersedes #108.