Merged
Conversation
Removed last nodejitsu reference
Contributor
Author
|
@jcrugzz @indexzero If one of you guys can sign off on this, we can go ahead and get this merged, cut a release, and then I'll work on getting some of the other PRs reviewed & merged to master. |
Contributor
|
@jsmylnycky I think this looks reasonable. @indexzero is on vacation so lets give him a day to see if he pops on here, otherwise ill merge. Thanks for this! |
Contributor
Author
|
@jcrugzz @indexzero /poke :) |
indexzero
approved these changes
Sep 5, 2019
Member
indexzero
left a comment
There was a problem hiding this comment.
Haven't used auto-changelog, but it's certainly a nice thing to automate 👍
jcrugzz
approved these changes
Sep 5, 2019
Contributor
Author
|
Merging, feel free to cut a release when you're ready! |
This was referenced Sep 5, 2020
This was referenced Sep 8, 2020
This was referenced Sep 9, 2020
This was referenced Mar 17, 2021
This was referenced Mar 19, 2021
Open
Open
calbearox
reviewed
Apr 17, 2022
calbearox
left a comment
There was a problem hiding this comment.
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
This was referenced Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have note used auto-changelog before, but it seems pretty useful and the formatting it performed looked about as good as one could hope. If you would prefer a different format, just let me know and I'll be happy to change it :) It should be wired up to automatically rebuild the changelog with the correct package.json version whenever
npm versionis ran.I also went through all of the most recent merges into Master and everything looked pretty good to me. The only things I caught were the nodejitsu reference, and I updated the engines block in package.json to conform to the travis-ci Node environments.