This fixes a Bug in the ValueResolver #2531
Merged
Conversation
…ter such that object values had null names
bbakerman
commented
Sep 1, 2021
|
|
||
| } | ||
|
|
||
| @Ignore("ObjectValue.isEqualTo is broken - this test currently makes no sense") |
Member
Author
There was a problem hiding this comment.
I had to Ignore this test because its broken - ObjectValue.isEqualTo is not implemented properly
That I dont think the code itself worths either because its an empty ObjectValue anyway.
But since this is not part of this PR - I am ignoring it to allow progress over perfection
(It will assert with the new asserts I put in - hence it will break but not for good reasons)
bbakerman
commented
Sep 1, 2021
| InputValueDefinition.newInputValueDefinition().build() | 'visitInputValueDefinition' | ||
| InputValueDefinition.newInputValueDefinition().build() | 'visitInputValueDefinition' | ||
| new ObjectField("", null) | 'visitObjectField' | ||
| new ObjectField("a", IntValue.of(1)) | 'visitObjectField' |
andimarek
approved these changes
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a Bug in the ValueResolver when called from the SchemaPrinter such that object values had null names
It also adds some handy
Value.ofmethods to make AST VALUE literals easier to use