Merged
Conversation
|
lets get this merged, latest release is breaking all of our nodejs auth0 apps |
stevehobbsdev
approved these changes
May 20, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
import = require()syntax to import a CommonJS styleexport =type from @types/expressReferences
fixes #309
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/express/index.d.ts
https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require
Testing
I'd like to remove the
esModuleInteropflag from https://github.com/auth0/node-jwks-rsa/blob/master/tsconfig.json#L16 so our CI tests would verify this, but I can't because outexpress-jwtdependencies require this. So tested manually with basic TS config.Checklist
master