Add keywords to Ajv options #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
requested changes
Dec 18, 2019
Member
epoberezkin
left a comment
There was a problem hiding this comment.
At the moment it adds formats, not keywords. The implementation, tests and types need to be updated.
0101e15 to
aa3123f
Compare
aa3123f to
c5ac6ce
Compare
epoberezkin
requested changes
Feb 16, 2020
| describe('keywords', function() { | ||
| it('should add keywords from options', function() { | ||
| var ajv = new Ajv({ keywords: { | ||
| identifier: { |
Member
There was a problem hiding this comment.
I suggest adding type: "string" in the keyword definition and changing the implementation to /^[a-z_$][a-z0-9_$]*$/i.test(data) so the example makes sense. Then the same tests can be used as in formats option test.
c5ac6ce to
38191c2
Compare
This was referenced Mar 15, 2020
This was referenced Apr 20, 2020
This was referenced Dec 14, 2021
This was referenced Sep 8, 2024
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
keywordsoption to the Ajv options to add custom keywords, without having to calladdKeyword.What issue does this pull request resolve?
#1136
What changes did you make?
Add the keywords option to the Ajv options to add custom keywords, without having to call addKeyword.
Is there anything that requires more attention while reviewing?
No