MAINT: Remove numpydoc version upper bound #32897
Conversation
lucyleeow
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good except the lint failure.
I would recommend you read our contributing guide before making PRs: https://scikit-learn.org/dev/developers/contributing.html#id1
It would be useful for the reviewer if you included the following information:
Fixed in numpy/numpydoc#622, which is included in the latest release: https://github.com/numpy/numpydoc/releases/tag/v1.10.0
| "pytest-cov": "<=6.3.0", | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Lint is probably failing due to this line.
There was a problem hiding this comment.
Thanks for the review! I have updated the PR description with the link to the numpydoc fix as requested.
It looks like the pre-commit.ci bot pushed a fix for the linting issues, so the checks should be passing now. Let me know if anything else is needed!
70cca09 to
b32e6f5
Compare
|
Thanks @lucyleeow! I have updated the PR description with the link you requested. I also ran ruff format locally and force-pushed the fix, so the linting issues should be resolved now. |
"This PR removes the <1.9.0 constraint for numpydoc in build_tools/update_environments_and_lock_files.py to allow CI to use newer versions. Note: I was unable to run the lockfile update script locally due to missing Conda environment tools. I am happy to let a maintainer (or the bot) update the lockfiles if needed."
Fixed in numpy/numpydoc#622, which is included in the latest release: https://github.com/numpy/numpydoc/releases/tag/v1.10.0