Add ff support and consolidated actions toolsets #1622
Merged
+2,436
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
copilot/add-generic-filtering-mechanisms
to
SamMorrowDrums/registry-builder-pattern
December 16, 2025 18:47
Base automatically changed from
SamMorrowDrums/registry-builder-pattern
to
SamMorrowDrums/server-tool-refactor-toolsets
December 16, 2025 18:53
Base automatically changed from
SamMorrowDrums/server-tool-refactor-toolsets
to
SamMorrowDrums/server-tool-refactor-projects
December 16, 2025 19:01
Base automatically changed from
SamMorrowDrums/server-tool-refactor-projects
to
SamMorrowDrums/server-tool-refactor-security-advisories
December 16, 2025 19:02
Base automatically changed from
SamMorrowDrums/server-tool-refactor-security-advisories
to
SamMorrowDrums/server-tool-refactor-discussions
December 16, 2025 19:02
Base automatically changed from
SamMorrowDrums/server-tool-refactor-discussions
to
SamMorrowDrums/server-tool-refactor-code-scanning
December 16, 2025 19:02
Base automatically changed from
SamMorrowDrums/server-tool-refactor-code-scanning
to
SamMorrowDrums/server-tool-refactor-git
December 16, 2025 19:02
Base automatically changed from
SamMorrowDrums/server-tool-refactor-git
to
SamMorrowDrums/server-tool-refactor-actions
December 16, 2025 19:03
Base automatically changed from
SamMorrowDrums/server-tool-refactor-actions
to
SamMorrowDrums/server-tool-refactor-pullrequests
December 16, 2025 19:03
Base automatically changed from
SamMorrowDrums/server-tool-refactor-pullrequests
to
SamMorrowDrums/server-tool-refactor-issues
December 16, 2025 19:36
Base automatically changed from
SamMorrowDrums/server-tool-refactor-issues
to
SamMorrowDrums/server-tool-refactor-repositories
December 16, 2025 19:38
Base automatically changed from
SamMorrowDrums/server-tool-refactor-repositories
to
SamMorrowDrums/server-tool-refactor-notifications
December 16, 2025 20:32
33662a0 to
daee6b8
Compare
Base automatically changed from
SamMorrowDrums/server-tool-refactor-notifications
to
SamMorrowDrums/server-tool-refactor
December 16, 2025 20:53
67e94d1 to
a3e151b
Compare
a3e151b to
94c7455
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds feature flag support for consolidated GitHub Actions tools, allowing the MCP server to switch between individual granular tools and consolidated multi-method tools. When the remote_mcp_consolidated_actions feature flag is enabled, four new consolidated tools replace 14 individual tools.
Key Changes
- Introduces
FeatureFlagConsolidatedActionsconstant to control tool availability via feature flags - Adds four new consolidated tools:
actions_list,actions_get,actions_run_trigger, andget_job_logs(consolidated version) - Sets
FeatureFlagDisableon all existing individual Actions tools to disable them when consolidated mode is active - Updates test validation logic to allow duplicate tool names for feature-flagged tools (since they're mutually exclusive at runtime)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/actions.go | Adds feature flag constant, method constants for consolidated tools, applies FeatureFlagDisable to 14 existing tools, implements 4 new consolidated tools with FeatureFlagEnable, and adds 13 helper functions to support consolidated tool operations |
| pkg/github/tools.go | Registers the 4 new consolidated tools in the AllTools function |
| pkg/github/tools_validation_test.go | Updates TestNoDuplicateToolNames to allow duplicate names for feature-flagged tools since they are mutually exclusive at runtime |
| cmd/github-mcp-server/main.go | Adds safety checks with viper.IsSet before unmarshaling tools and features configuration to prevent errors when keys are absent |
| README.md | Documents the 4 new consolidated tools with their parameters and descriptions |
| assert.Contains(t, inputSchema.Properties, "run_id") | ||
| assert.ElementsMatch(t, inputSchema.Required, []string{"owner", "repo", "run_id"}) | ||
|
|
||
| tests := []struct { |
There was a problem hiding this comment.
The test structure starting at line 1454 appears to be orphaned or incorrectly placed within the Test_RerunFailedJobs function. This test table should either be part of a new test function or removed if it duplicates the existing test logic above it.
bretthowell714-source
approved these changes
Dec 18, 2025
SamMorrowDrums
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request completes the Actions consolidation rollout by porting these changes back to OSS and allowing feature flags to be used to control which version of the Actions toolset is enabled: legacy or consolidated.
Closes: https://github.com/github/copilot-agent-services/issues/1053