feat: add initial API for boundary log forwarding to coderd #21293
+1,367
−779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the API changes to support the feature that transmits boundary logs from workspaces to coderd via the agent API, then re-emits them to stderr. Architecture: - Boundary process connects to Unix socket - Boundary batches logs and sends TLV prefixed protobuf ReportBoundaryLogsRequest messages to Agent - Agent proxies messages to coderd via DRPC - coderd re-emits to stderr
zedkipp
commented
Dec 16, 2025
zedkipp
commented
Dec 16, 2025
agent/proto/agent.proto
Outdated
| rpc CreateSubAgent(CreateSubAgentRequest) returns (CreateSubAgentResponse); | ||
| rpc DeleteSubAgent(DeleteSubAgentRequest) returns (DeleteSubAgentResponse); | ||
| rpc ListSubAgents(ListSubAgentsRequest) returns (ListSubAgentsResponse); | ||
| rpc ReportBoundaryLogs(ReportBoundaryLogsRequest) returns (ReportBoundaryLogsResponse); |
Contributor
Author
There was a problem hiding this comment.
Any opinions on this RPC name?
This module will be imported by boundary to access the generated code to create messages to forward to the workspace agent.
spikecurtis
reviewed
Dec 17, 2025
| // by boundary, which lives in a separate repository. | ||
| require github.com/coder/coder/v2/agent/proto/boundary_logs v0.0.0-incompatible | ||
|
|
||
| replace github.com/coder/coder/v2/agent/proto/boundary_logs => ./agent/proto/boundary_logs |
Contributor
There was a problem hiding this comment.
I don't understand why this is needed and the comment is not really helping.
johnstcn
reviewed
Dec 17, 2025
Member
johnstcn
left a comment
There was a problem hiding this comment.
Proto changes look OK to me but I'm less certain about having them in the coder/coder repo. What would you think about inverting the direction of the import?
| repeated SubAgent agents = 1; | ||
| } | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the API changes to support the feature that transmits boundary logs from workspaces to coderd via the agent API for eventual re-emission to stderr. The API handlers are stubs for now because I'm trying to land this feature from multiple smaller PRs.
High level architecture:
RFC: https://www.notion.so/coderhq/Agent-Boundary-Logs-2afd579be59280f29629fc9823ac41ba