Skip to content

chore!: promote AIBridge from ExperimentalHandler #21278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakehwll merged 8 commits into from
Dec 17, 2025
Merged

chore!: promote AIBridge from ExperimentalHandler #21278

jakehwll merged 8 commits into from
Dec 17, 2025
+273 −239

Conversation

@jakehwll
Copy link
Contributor

@jakehwll jakehwll commented Dec 15, 2025 •
edited
Loading

Addressing feedback found in #21252

Important

This pull-request removes endpoints from ExperimentalHandler from coderd.go and promotes the endpoints within the frontend. This means that we will no longer be serving AI Bridge under the /api/experimental/ prefix now that things reached release in v2.29.0.

Migration

The /api/experimental/aibridge prefix has been removed. Any clients, scripts, or integrations that previously called AI Bridge endpoints under /api/experimental/aibridge must be updated to use the /api/v2/aibridge stable API routes introduced in v2.29.0.

Position Pull-request
fix: improve AI Bridge request logs UI/UX
feat: add AI Bridge request logs model filter
✅ fix: promote AIBridge from ExperimentalHandler

This was referenced Dec 15, 2025
Open
Open
Merged
dannykopping
dannykopping reviewed Dec 15, 2025
View reviewed changes
@matifali
Copy link
Member

matifali commented Dec 15, 2025

Should this be marked as a breaking change?

@jakehwll jakehwll changed the title fix: promote AIBridge from ExperimentalHandler fix!: promote AIBridge from ExperimentalHandler Dec 16, 2025
@matifali matifali added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Dec 16, 2025
ssncferreira
ssncferreira reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not in the scope of this PR, but just to confirm: should /api/experimental/mcp/http be promoted to /api/v2 as well, or is MCP intentionally staying experimental?

@jakehwll jakehwll marked this pull request as ready for review December 16, 2025 13:32
@jakehwll
Copy link
Contributor Author

jakehwll commented Dec 16, 2025

Probably not in the scope of this PR, but just to confirm: should /api/experimental/mcp/http be promoted to /api/v2 as well, or is MCP intentionally staying experimental?

Its to my understanding that we are promoting AI Bridge and not the MCP server just yet 🙂

@matifali
Copy link
Member

matifali commented Dec 16, 2025 •
edited
Loading

@jakehwll should this be instead a chore:? We use these labels to generate a changelog, and it will come up as a bug fix. Is it?

Also, can you add two lines to the PR body describing what is breaking and how to migrate? We can then copy those to ChangeLog as it is.

@jakehwll jakehwll changed the title fix!: promote AIBridge from ExperimentalHandler chore!: promote AIBridge from ExperimentalHandler Dec 17, 2025
@jakehwll
Copy link
Contributor Author

jakehwll commented Dec 17, 2025

@jakehwll should this be instead a chore:? We use these labels to generate a changelog, and it will come up as a bug fix. Is it?

Also, can you add two lines to the PR body describing what is breaking and how to migrate? We can then copy those to ChangeLog as it is.

Thats a very good point, this was a "fix" in my mind as its something we were supposed to do in v2.29.0. I've updated and given a migration path 🙂

dannykopping
dannykopping reviewed Dec 17, 2025
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

ssncferreira
ssncferreira reviewed Dec 17, 2025
View reviewed changes
@ssncferreira
Copy link
Contributor

ssncferreira commented Dec 17, 2025

The /api/experimental/aibridge prefix has been removed. Any clients, scripts, or integrations that previously called AI Bridge endpoints under /api/v2/aibridge must be updated to use the /api/v2/aibridge stable API routes introduced in v2.29.0.

I think there is a small typo in the PR description for the migration, should be /api/experimental/aibridge:
...called AI Bridge endpoints under /api/experimental/aibridge must be updated to use the /api/v2/aibridge stable API routes...

ssncferreira
ssncferreira approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jakehwll jakehwll merged commit dceecec into jakehwll/ai-bridge-request-logs-model Dec 17, 2025
37 checks passed
@jakehwll jakehwll deleted the jakehwll/ai-bridge-experimentalhandler branch December 17, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannykopping dannykopping dannykopping left review comments

@ssncferreira ssncferreira ssncferreira approved these changes

Assignees

@jakehwll jakehwll

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jakehwll @matifali @ssncferreira @dannykopping