chore: create Workspace sharing form component using workspace sharing hook #21276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Dec 15, 2025
Member
There was a problem hiding this comment.
in this context where the component is still only being used in one place, I'd prefer to leave it in the pages/ directory. modules/ should mostly be multi-purpose stuff.
Contributor
Author
There was a problem hiding this comment.
I put it here because in the next PR this component will be used in multiple places
site/src/modules/workspaces/WorkspaceSharingForm/WorkspaceSharingForm.tsx
Outdated
Show resolved
Hide resolved
aded7e8 to
e0ef70c
Compare
8d62b35 to
388800a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separate the data retrieval for workspace sharing ACL into a custom hook and creates a separate form component. This is in preparation for reusing the workspace sharing form from a new share button on the workspace page.