From e072ef3facbe13c51237656bd3c0ea49c746dadf Mon Sep 17 00:00:00 2001 From: Yorik Timo Hansen Date: Thu, 29 Aug 2024 16:41:40 +0200 Subject: [PATCH 1/6] Add dark mode support to pages generated by http.server The error pages and the directory lists generated by http.server did not allow browsers to enable the inbuilt dark mode. This change allows for that by setting the css property color-scheme properly. --- Lib/http/server.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Lib/http/server.py b/Lib/http/server.py index 2d010649e56b51..a6f7aecc78763f 100644 --- a/Lib/http/server.py +++ b/Lib/http/server.py @@ -114,6 +114,11 @@ + Error response @@ -804,6 +809,7 @@ def list_directory(self, path): r.append('') r.append('') r.append(f'') + r.append('') r.append(f'{title}\n') r.append(f'\n

{title}

') r.append('

Date: Thu, 29 Aug 2024 17:14:19 +0200 Subject: [PATCH 3/6] Update Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst Co-authored-by: Peter Bierma --- .../next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst b/Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst index 1df044425264be..99e964fcda582e 100644 --- a/Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst +++ b/Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst @@ -1 +1 @@ -Pages generated by the ``http.server`` module allow the brower to apply it's default dark mode. +Pages generated by the :mod:`http.server` module allow the brower to apply its default dark mode. From bb147a6497c3cbd98d69e2b64e95d879a3708a8e Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 3 Sep 2024 02:50:16 +0200 Subject: [PATCH 4/6] Update Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst --- .../next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst b/Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst index 99e964fcda582e..0afdad7917fa8f 100644 --- a/Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst +++ b/Misc/NEWS.d/next/Library/2024-08-29-14-51-36.gh-issue-123430.M7wXl9.rst @@ -1 +1 @@ -Pages generated by the :mod:`http.server` module allow the brower to apply its default dark mode. +Pages generated by the :mod:`http.server` module allow the browser to apply its default dark mode. From d5672e7e5ffa54c1a6c6c2d3c75007348c06a09d Mon Sep 17 00:00:00 2001 From: Yorik Hansen Date: Tue, 3 Sep 2024 07:51:37 +0200 Subject: [PATCH 5/6] Added darkmode note to whatsnew --- Doc/whatsnew/3.14.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Doc/whatsnew/3.14.rst b/Doc/whatsnew/3.14.rst index ba18991dee89d7..126b59a5a0189c 100644 --- a/Doc/whatsnew/3.14.rst +++ b/Doc/whatsnew/3.14.rst @@ -151,6 +151,14 @@ Added support for converting any objects that have the (Contributed by Serhiy Storchaka in :gh:`82017`.) +http +---- + +Directory lists and error pages generated by the :mod:`http.server` +module allow the browser to apply its default dark mode. +(Contributed by Yorik Hansen in :gh:`123430`.) + + json ---- From ffb1fcd6c763937be295221d6e9e048bdc068e8f Mon Sep 17 00:00:00 2001 From: Yorik Hansen Date: Tue, 3 Sep 2024 07:54:56 +0200 Subject: [PATCH 6/6] Trimmed trailing whitespace (sorry) --- Doc/whatsnew/3.14.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc/whatsnew/3.14.rst b/Doc/whatsnew/3.14.rst index 126b59a5a0189c..8efff2613f60c4 100644 --- a/Doc/whatsnew/3.14.rst +++ b/Doc/whatsnew/3.14.rst @@ -154,7 +154,7 @@ Added support for converting any objects that have the http ---- -Directory lists and error pages generated by the :mod:`http.server` +Directory lists and error pages generated by the :mod:`http.server` module allow the browser to apply its default dark mode. (Contributed by Yorik Hansen in :gh:`123430`.)