Moving the llc,urc paramaters to the ViewParams class#110
Merged
kkiesling merged 1 commit intoopenmc-dev:developfrom Feb 10, 2023
Merged
Moving the llc,urc paramaters to the ViewParams class#110kkiesling merged 1 commit intoopenmc-dev:developfrom
kkiesling merged 1 commit intoopenmc-dev:developfrom
Conversation
Member
|
I think @billingsley-john and myself came across this in the York neutronics workshop and couldn't figure out what was going on. Thanks for the fix Patrick Note to self, merge this will cause conflicts with this other PR #108 |
kkiesling
approved these changes
Feb 10, 2023
Contributor
kkiesling
left a comment
There was a problem hiding this comment.
Thanks for fixing this @pshriwise - lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noted today that our VTK export capability was broken b/c the export dialog box couldn't find these when trying to populate initial values. Moving these attributes from the
PlotViewIndependentclass to theViewParamclass.