From 0ba48e238085c1d3861916feb736e0e5215d9a47 Mon Sep 17 00:00:00 2001 From: Suhaib Mujahid Date: Mon, 8 Sep 2025 12:59:17 -0400 Subject: [PATCH 1/2] Add debug prints to test_find_comment_scope Added print statements to output revision URL, raw diff, patch set, and file name during test execution for easier debugging and inspection of test data. --- tests/test_code_review.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/test_code_review.py b/tests/test_code_review.py index cbd45c71fb..5a15c1cc1f 100644 --- a/tests/test_code_review.py +++ b/tests/test_code_review.py @@ -45,10 +45,16 @@ def test_find_comment_scope(): } for revision_url, patch_files in test_data.items(): + print(f"## Testing {revision_url} ##") raw_diff = requests.get(revision_url + "&download=true", timeout=5).text + print("## Raw Diff ##") + print(raw_diff) patch_set = PatchSet.from_string(raw_diff) + print("## Patch Set ##") + print(patch_set) for file_name, target_hunks in patch_files.items(): + print(f"## Testing {file_name} ##") patched_file = next( patched_file for patched_file in patch_set From b3006ffbcec5e7268020b4201e45677600a3e6fd Mon Sep 17 00:00:00 2001 From: Suhaib Mujahid Date: Mon, 8 Sep 2025 13:20:48 -0400 Subject: [PATCH 2/2] Add error handling for HTTP requests in test Added resp.raise_for_status() to ensure HTTP errors are caught when downloading diffs in test_find_comment_scope. This improves test reliability by failing fast on bad responses. --- tests/test_code_review.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test_code_review.py b/tests/test_code_review.py index 5a15c1cc1f..c6261ba84f 100644 --- a/tests/test_code_review.py +++ b/tests/test_code_review.py @@ -46,7 +46,9 @@ def test_find_comment_scope(): for revision_url, patch_files in test_data.items(): print(f"## Testing {revision_url} ##") - raw_diff = requests.get(revision_url + "&download=true", timeout=5).text + resp = requests.get(revision_url + "&download=true", timeout=5) + resp.raise_for_status() + raw_diff = resp.text print("## Raw Diff ##") print(raw_diff) patch_set = PatchSet.from_string(raw_diff)