From 39021484489e6a48cae307524231492a4c366079 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos <6349682+vaind@users.noreply.github.com> Date: Mon, 3 Nov 2025 11:33:35 +0100 Subject: [PATCH 1/4] fix(tests): skip basic_transport_thread_name test on NX platform (#1439) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The basic_transport_thread_name test fails on NX (Nintendo Switch) because the transport won't start without a custom network_connect_func. This change adds a platform check to skip the test on NX, preventing false test failures on that platform. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude --- tests/unit/test_basic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/unit/test_basic.c b/tests/unit/test_basic.c index 095d59bd36..ea7d565cce 100644 --- a/tests/unit/test_basic.c +++ b/tests/unit/test_basic.c @@ -305,6 +305,11 @@ SENTRY_TEST(capture_minidump_invalid_path) SENTRY_TEST(basic_transport_thread_name) { +#if defined(SENTRY_PLATFORM_NX) + // NX transport won't start without custom network_connect_func. + SKIP_TEST(); +#endif + const char *expected_thread_name = "sentry::worker_thread"; SENTRY_TEST_OPTIONS_NEW(options); From d8f3c78af98a547d980bd9b1a1b2ee5a78fb1d0b Mon Sep 17 00:00:00 2001 From: Ivan Dlugos <6349682+vaind@users.noreply.github.com> Date: Mon, 3 Nov 2025 11:33:55 +0100 Subject: [PATCH 2/4] fix: correct sentry__process_spawn signature in none implementation (#1436) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: correct sentry__process_spawn signature in none implementation PR #1413 changed the arg0 parameter from sentry_pathchar_t* to char* as part of making narrow UTF-8 the canonical path encoding, but the signature in sentry_process_none.c was not updated. This fixes the function signature to match the declaration, changing arg0 from `const sentry_pathchar_t *` to `const char *`. Fixes regression from #1413 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude * Update CHANGELOG with unreleased fixes Added unreleased section with fixes for PS5/Switch compilation regression. --------- Co-authored-by: Claude --- CHANGELOG.md | 6 ++++++ src/process/sentry_process_none.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c22c7f232b..f322c46d9b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +**Fixes**: + +- PS5/Switch compilation regression (`sentry__process_spawn` signature change) ([#1436](https://github.com/getsentry/sentry-native/pull/1436)) + ## 0.12.0 **Breaking changes**: diff --git a/src/process/sentry_process_none.c b/src/process/sentry_process_none.c index c6c3f2d4c4..8f24d4b8c0 100644 --- a/src/process/sentry_process_none.c +++ b/src/process/sentry_process_none.c @@ -3,7 +3,7 @@ #include "sentry_core.h" void -sentry__process_spawn(const sentry_path_t *UNUSED(executable), - const sentry_pathchar_t *UNUSED(arg0), ...) +sentry__process_spawn( + const sentry_path_t *UNUSED(executable), const char *UNUSED(arg0), ...) { } From 7e96a5e1573228949f3c2821ef140b3f02a41357 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos <6349682+vaind@users.noreply.github.com> Date: Mon, 3 Nov 2025 11:34:07 +0100 Subject: [PATCH 3/4] fix(tests): add SENTRY_TEST_PATH_PREFIX to crash_marker test database path (#1437) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The crash_marker test creates a database directory but was not using SENTRY_TEST_PATH_PREFIX like other tests. This could cause the test to write to an unexpected location on some platforms. This change ensures the database path is properly prefixed with the test path prefix, making it consistent with other tests in the suite. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude --- tests/unit/test_basic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/unit/test_basic.c b/tests/unit/test_basic.c index ea7d565cce..919a52616f 100644 --- a/tests/unit/test_basic.c +++ b/tests/unit/test_basic.c @@ -155,7 +155,8 @@ SENTRY_TEST(discarding_before_send) SENTRY_TEST(crash_marker) { // We don't use sentry_init() in this test so we must create a database dir - sentry_path_t *database_path = sentry__path_from_str(".sentry-native"); + sentry_path_t *database_path + = sentry__path_from_str(SENTRY_TEST_PATH_PREFIX ".sentry-native"); TEST_ASSERT(!!database_path); TEST_ASSERT(!sentry__path_create_dir_all(database_path)); From fee13ac2e74d7a00504cf9f837f34e73718d0655 Mon Sep 17 00:00:00 2001 From: getsentry-bot Date: Mon, 3 Nov 2025 10:37:33 +0000 Subject: [PATCH 4/4] release: 0.12.1 --- CHANGELOG.md | 2 +- include/sentry.h | 2 +- ndk/gradle.properties | 2 +- tests/__init__.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f322c46d9b..356b9ede89 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -## Unreleased +## 0.12.1 **Fixes**: diff --git a/include/sentry.h b/include/sentry.h index bf5a7c15e8..7e69e01054 100644 --- a/include/sentry.h +++ b/include/sentry.h @@ -100,7 +100,7 @@ extern "C" { # endif #endif #ifndef SENTRY_SDK_VERSION -# define SENTRY_SDK_VERSION "0.12.0" +# define SENTRY_SDK_VERSION "0.12.1" #endif #define SENTRY_SDK_USER_AGENT SENTRY_SDK_NAME "/" SENTRY_SDK_VERSION diff --git a/ndk/gradle.properties b/ndk/gradle.properties index c3fbd657f3..c215d50825 100644 --- a/ndk/gradle.properties +++ b/ndk/gradle.properties @@ -7,7 +7,7 @@ org.gradle.parallel=true android.useAndroidX=true # Release information, used for maven publishing -versionName=0.12.0 +versionName=0.12.1 # disable renderscript, it's enabled by default android.defaults.buildfeatures.renderscript=false diff --git a/tests/__init__.py b/tests/__init__.py index a613e188a4..9a25197ccf 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -15,7 +15,7 @@ # https://docs.pytest.org/en/latest/assert.html#assert-details pytest.register_assert_rewrite("tests.assertions") -SENTRY_VERSION = "0.12.0" +SENTRY_VERSION = "0.12.1" def make_dsn(httpserver, auth="uiaeosnrtdy", id=123456, proxy_host=False):