From 969837b1808843f0210c8f574ef7f1032299526d Mon Sep 17 00:00:00 2001 From: Miedviediev Dmytro Date: Mon, 16 Oct 2023 11:46:48 +0300 Subject: [PATCH 1/3] Fix critical issue with saving results in BigQuery Need to encapsulate table path as tmp table path can contain symbols that can't be process by BigQuery without encapsulation Signed-off-by: Dmytro Miedviediev --- sdk/python/feast/infra/offline_stores/bigquery.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/feast/infra/offline_stores/bigquery.py b/sdk/python/feast/infra/offline_stores/bigquery.py index 86c587c7fd2..10c8aa783fb 100644 --- a/sdk/python/feast/infra/offline_stores/bigquery.py +++ b/sdk/python/feast/infra/offline_stores/bigquery.py @@ -515,7 +515,7 @@ def to_bigquery( temp_dest_table = f"{tmp_dest['projectId']}.{tmp_dest['datasetId']}.{tmp_dest['tableId']}" # persist temp table - sql = f"CREATE TABLE `{dest}` AS SELECT * FROM {temp_dest_table}" + sql = f"CREATE TABLE `{dest}` AS SELECT * FROM `{temp_dest_table}`" self._execute_query(sql, timeout=timeout) print(f"Done writing to '{dest}'.") From 741d38f8ee1415dd7ac7398695a47cbe22c1dbc6 Mon Sep 17 00:00:00 2001 From: Miedviediev Dmytro Date: Mon, 16 Oct 2023 15:11:16 +0300 Subject: [PATCH 2/3] update numpy Signed-off-by: Dmytro Miedviediev --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 047100f03eb..7f531175142 100644 --- a/setup.py +++ b/setup.py @@ -54,7 +54,7 @@ "Jinja2>=2,<4", "jsonschema", "mmh3", - "numpy>=1.22,<1.25", + "numpy>=1.22,<1.27", "pandas>=1.4.3,<2", # For some reason pandavro higher than 1.5.* only support pandas less than 1.3. "pandavro~=1.5.0", From 365a018835b663a7362876f3b19d8430d05650a0 Mon Sep 17 00:00:00 2001 From: Miedviediev Dmytro Date: Mon, 16 Oct 2023 15:14:00 +0300 Subject: [PATCH 3/3] revert numpy version Signed-off-by: Dmytro Miedviediev --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 7f531175142..047100f03eb 100644 --- a/setup.py +++ b/setup.py @@ -54,7 +54,7 @@ "Jinja2>=2,<4", "jsonschema", "mmh3", - "numpy>=1.22,<1.27", + "numpy>=1.22,<1.25", "pandas>=1.4.3,<2", # For some reason pandavro higher than 1.5.* only support pandas less than 1.3. "pandavro~=1.5.0",