From ab245e9a90555e4fcdf93fb7e0d98e2b3cbd552c Mon Sep 17 00:00:00 2001 From: Tomas Pereira de Vasconcelos Date: Mon, 14 Mar 2022 22:22:55 +0100 Subject: [PATCH 01/21] add py.typed marker Signed-off-by: Tomas Pereira de Vasconcelos --- sdk/python/feast/py.typed | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 sdk/python/feast/py.typed diff --git a/sdk/python/feast/py.typed b/sdk/python/feast/py.typed new file mode 100644 index 00000000000..e69de29bb2d From e1578db4c17e6a7ccb704e14bbc064d71e150e3f Mon Sep 17 00:00:00 2001 From: Tomas Pereira de Vasconcelos Date: Mon, 14 Mar 2022 22:29:39 +0100 Subject: [PATCH 02/21] add py.typed to MANIFEST.in Signed-off-by: Tomas Pereira de Vasconcelos --- sdk/python/MANIFEST.in | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/python/MANIFEST.in b/sdk/python/MANIFEST.in index 46b56a04d45..c5f6b71418f 100644 --- a/sdk/python/MANIFEST.in +++ b/sdk/python/MANIFEST.in @@ -1,2 +1,3 @@ recursive-include feast/protos/ *.py include feast/binaries/* +recursive-include feast py.typed *.pyi From e99e8b546c998866ba7056527f308a08dc27899d Mon Sep 17 00:00:00 2001 From: Tomas Pereira de Vasconcelos Date: Mon, 14 Mar 2022 23:23:24 +0100 Subject: [PATCH 03/21] ignore mypy error from generated protos modules Signed-off-by: Tomas Pereira de Vasconcelos --- Makefile | 2 +- sdk/python/setup.cfg | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index ae776771cd2..ba87a2711a0 100644 --- a/Makefile +++ b/Makefile @@ -92,7 +92,7 @@ format-python: cd ${ROOT_DIR}/sdk/python; python -m black --target-version py37 feast tests lint-python: - cd ${ROOT_DIR}/sdk/python; python -m mypy feast/ tests/ + cd ${ROOT_DIR}/sdk/python; python -m mypy cd ${ROOT_DIR}/sdk/python; python -m isort feast/ tests/ --check-only cd ${ROOT_DIR}/sdk/python; python -m flake8 feast/ tests/ cd ${ROOT_DIR}/sdk/python; python -m black --check feast tests diff --git a/sdk/python/setup.cfg b/sdk/python/setup.cfg index ae8fe14ba16..0cd4940e0d4 100644 --- a/sdk/python/setup.cfg +++ b/sdk/python/setup.cfg @@ -1,4 +1,5 @@ [isort] +src_paths = feast,tests multi_line_output=3 include_trailing_comma=True force_grid_wrap=0 @@ -16,5 +17,7 @@ select = B,C,E,F,W,T4 exclude = .git,__pycache__,docs/conf.py,dist,feast/protos [mypy] -files=feast,test +files=feast,tests ignore_missing_imports=true +# ignore mypy error from generated protos modules +exclude=feast/protos/* From 1bdbe78cb148f119c4c2e8780651e3bc785e15d9 Mon Sep 17 00:00:00 2001 From: Tomas Pereira de Vasconcelos Date: Wed, 16 Mar 2022 09:53:31 +0100 Subject: [PATCH 04/21] revert: ignore mypy error from generated protos modules Signed-off-by: Tomas Pereira de Vasconcelos --- sdk/python/setup.cfg | 2 -- 1 file changed, 2 deletions(-) diff --git a/sdk/python/setup.cfg b/sdk/python/setup.cfg index 0cd4940e0d4..ce8f391eb16 100644 --- a/sdk/python/setup.cfg +++ b/sdk/python/setup.cfg @@ -19,5 +19,3 @@ exclude = .git,__pycache__,docs/conf.py,dist,feast/protos [mypy] files=feast,tests ignore_missing_imports=true -# ignore mypy error from generated protos modules -exclude=feast/protos/* From 64de0866d1de2ea970d802af585342633a3eddaa Mon Sep 17 00:00:00 2001 From: Achal Shah Date: Mon, 21 Mar 2022 17:05:57 -0700 Subject: [PATCH 05/21] reorder imports Signed-off-by: Achal Shah Signed-off-by: Tomas Pereira de Vasconcelos --- sdk/python/feast/go_server.py | 2 +- sdk/python/feast/transformation_server.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/python/feast/go_server.py b/sdk/python/feast/go_server.py index 1fcbab61f08..38a350fd6d2 100644 --- a/sdk/python/feast/go_server.py +++ b/sdk/python/feast/go_server.py @@ -25,10 +25,10 @@ from subprocess import Popen from typing import Any, Dict, List, Optional, Union -import grpc from tenacity import retry, stop_after_attempt, stop_after_delay, wait_exponential import feast +import grpc from feast.errors import FeatureNameCollisionError, InvalidFeaturesParameterType from feast.feature_service import FeatureService from feast.flags_helper import is_test diff --git a/sdk/python/feast/transformation_server.py b/sdk/python/feast/transformation_server.py index 83f4af749e3..8e0efd73137 100644 --- a/sdk/python/feast/transformation_server.py +++ b/sdk/python/feast/transformation_server.py @@ -2,10 +2,10 @@ import sys from concurrent import futures -import grpc import pyarrow as pa from grpc_reflection.v1alpha import reflection +import grpc from feast.errors import OnDemandFeatureViewNotFoundException from feast.feature_store import FeatureStore from feast.protos.feast.serving.TransformationService_pb2 import ( From 29d5272e829c80eb7b5105c872163529e9a8ede4 Mon Sep 17 00:00:00 2001 From: Tomas Pereira de Vasconcelos Date: Tue, 22 Mar 2022 18:33:09 +0100 Subject: [PATCH 06/21] sort imports Signed-off-by: Tomas Pereira de Vasconcelos --- sdk/python/feast/go_server.py | 2 +- sdk/python/feast/transformation_server.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk/python/feast/go_server.py b/sdk/python/feast/go_server.py index 38a350fd6d2..1fcbab61f08 100644 --- a/sdk/python/feast/go_server.py +++ b/sdk/python/feast/go_server.py @@ -25,10 +25,10 @@ from subprocess import Popen from typing import Any, Dict, List, Optional, Union +import grpc from tenacity import retry, stop_after_attempt, stop_after_delay, wait_exponential import feast -import grpc from feast.errors import FeatureNameCollisionError, InvalidFeaturesParameterType from feast.feature_service import FeatureService from feast.flags_helper import is_test diff --git a/sdk/python/feast/transformation_server.py b/sdk/python/feast/transformation_server.py index 8e0efd73137..cb0a3bfc505 100644 --- a/sdk/python/feast/transformation_server.py +++ b/sdk/python/feast/transformation_server.py @@ -2,6 +2,7 @@ import sys from concurrent import futures +import grpc import pyarrow as pa from grpc_reflection.v1alpha import reflection From e47a32bf0951dc4d11dfeab49e43443a8d5f55e4 Mon Sep 17 00:00:00 2001 From: Tomas Pereira de Vasconcelos Date: Tue, 22 Mar 2022 18:33:47 +0100 Subject: [PATCH 07/21] sort imports Signed-off-by: Tomas Pereira de Vasconcelos --- sdk/python/feast/transformation_server.py | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/python/feast/transformation_server.py b/sdk/python/feast/transformation_server.py index cb0a3bfc505..83f4af749e3 100644 --- a/sdk/python/feast/transformation_server.py +++ b/sdk/python/feast/transformation_server.py @@ -6,7 +6,6 @@ import pyarrow as pa from grpc_reflection.v1alpha import reflection -import grpc from feast.errors import OnDemandFeatureViewNotFoundException from feast.feature_store import FeatureStore from feast.protos.feast.serving.TransformationService_pb2 import ( From 99783f2472e9bf292d960f267fce98542cf7f1cc Mon Sep 17 00:00:00 2001 From: Oleksii Moskalenko Date: Mon, 21 Mar 2022 19:46:46 +0200 Subject: [PATCH 08/21] feat: Allow using entity's join_key in get_online_features (#2420) * allowing using entity's join_key in get_online_features Signed-off-by: pyalex * fix tests Signed-off-by: pyalex Signed-off-by: Tomas Pereira de Vasconcelos From adfe75495c2dad4a3ca755cd097d49d50bbccef9 Mon Sep 17 00:00:00 2001 From: Oleksii Moskalenko Date: Mon, 21 Mar 2022 20:34:46 +0200 Subject: [PATCH 09/21] =?UTF-8?q?fix!:=20GetOnlineFeatureResponse=20in=20P?= =?UTF-8?q?ython=20feature=20server=20should=20be=20consisten=E2=80=A6=20(?= =?UTF-8?q?#2418)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * GetOnlineFeatureResponse in Python feature server should be consistent with Java implementation Signed-off-by: pyalex * fix local e2e test Signed-off-by: pyalex * reuse timestamp in response generation Signed-off-by: pyalex Signed-off-by: Tomas Pereira de Vasconcelos From 74f1e041e6ff95477886105daf76e2fecb021b2d Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Mon, 21 Mar 2022 12:23:46 -0700 Subject: [PATCH 10/21] chore: Adding documentation on community calendar + newsletter + updating CONTRIBUTING.md (#2425) * chore: Adding documentation on community calendar + newsletter and cross linking more on how to contribute to Feast Signed-off-by: Danny Chiao * fix PR template Signed-off-by: Danny Chiao * fix PR template Signed-off-by: Danny Chiao Signed-off-by: Tomas Pereira de Vasconcelos From b6d6afca396dac71d3f992cbaff155c3cd60d3f6 Mon Sep 17 00:00:00 2001 From: Achal Shah Date: Mon, 21 Mar 2022 13:01:46 -0700 Subject: [PATCH 11/21] feat: Graduate write_to_online_store out of experimental status (#2426) Signed-off-by: Achal Shah Signed-off-by: Tomas Pereira de Vasconcelos From 2679658b0f46a7332538043a63dc7c213e99d661 Mon Sep 17 00:00:00 2001 From: Felix Wang Date: Mon, 21 Mar 2022 16:43:48 -0700 Subject: [PATCH 12/21] refactor!: Remove deprecated parameters from Entity and FeatureView (#2427) * Remove labels parameter from Entity Signed-off-by: Felix Wang * Remove input parameter and deprecate Duration type for ttl parameter in FeatureView Signed-off-by: Felix Wang * Change examples to stop using Duration Signed-off-by: Felix Wang * Delete unused example feature repo Signed-off-by: Felix Wang * Format Signed-off-by: Felix Wang Signed-off-by: Tomas Pereira de Vasconcelos From 2bfc6bbd3c668d240e36246433de96339dfd71b2 Mon Sep 17 00:00:00 2001 From: Felix Wang Date: Mon, 21 Mar 2022 16:55:46 -0700 Subject: [PATCH 13/21] ci: Modify release script to only do minor release for breaking changes (#2431) Signed-off-by: Felix Wang Signed-off-by: Tomas Pereira de Vasconcelos From 022cca10bb002cc601857039f7d28654bebd3852 Mon Sep 17 00:00:00 2001 From: Achal Shah Date: Mon, 21 Mar 2022 23:31:01 -0700 Subject: [PATCH 14/21] fix: Ensure that __init__ files exist in proto dirs (#2433) Signed-off-by: Achal Shah Signed-off-by: Tomas Pereira de Vasconcelos From 8861213e8d7e8bb318588fe6caf20c863e5b9008 Mon Sep 17 00:00:00 2001 From: Oleksii Moskalenko Date: Mon, 21 Mar 2022 19:46:46 +0200 Subject: [PATCH 15/21] feat: Allow using entity's join_key in get_online_features (#2420) * allowing using entity's join_key in get_online_features Signed-off-by: pyalex * fix tests Signed-off-by: pyalex Signed-off-by: Tomas Pereira de Vasconcelos From aa74ee2041a9e187f2a078933daf802ca72cdc7a Mon Sep 17 00:00:00 2001 From: Oleksii Moskalenko Date: Mon, 21 Mar 2022 20:34:46 +0200 Subject: [PATCH 16/21] =?UTF-8?q?fix!:=20GetOnlineFeatureResponse=20in=20P?= =?UTF-8?q?ython=20feature=20server=20should=20be=20consisten=E2=80=A6=20(?= =?UTF-8?q?#2418)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * GetOnlineFeatureResponse in Python feature server should be consistent with Java implementation Signed-off-by: pyalex * fix local e2e test Signed-off-by: pyalex * reuse timestamp in response generation Signed-off-by: pyalex Signed-off-by: Tomas Pereira de Vasconcelos From a2f4c3b5b3c584d2ea42405391b67b174851d026 Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Mon, 21 Mar 2022 12:23:46 -0700 Subject: [PATCH 17/21] chore: Adding documentation on community calendar + newsletter + updating CONTRIBUTING.md (#2425) * chore: Adding documentation on community calendar + newsletter and cross linking more on how to contribute to Feast Signed-off-by: Danny Chiao * fix PR template Signed-off-by: Danny Chiao * fix PR template Signed-off-by: Danny Chiao Signed-off-by: Tomas Pereira de Vasconcelos From 8be62c9324037529514b6e9376881d4a3178a565 Mon Sep 17 00:00:00 2001 From: Achal Shah Date: Mon, 21 Mar 2022 13:01:46 -0700 Subject: [PATCH 18/21] feat: Graduate write_to_online_store out of experimental status (#2426) Signed-off-by: Achal Shah Signed-off-by: Tomas Pereira de Vasconcelos From cde237a3499ab729b2b074ef75f8ad48acf4fdc7 Mon Sep 17 00:00:00 2001 From: Felix Wang Date: Mon, 21 Mar 2022 16:43:48 -0700 Subject: [PATCH 19/21] refactor!: Remove deprecated parameters from Entity and FeatureView (#2427) * Remove labels parameter from Entity Signed-off-by: Felix Wang * Remove input parameter and deprecate Duration type for ttl parameter in FeatureView Signed-off-by: Felix Wang * Change examples to stop using Duration Signed-off-by: Felix Wang * Delete unused example feature repo Signed-off-by: Felix Wang * Format Signed-off-by: Felix Wang Signed-off-by: Tomas Pereira de Vasconcelos From 849c1cb17cd55aa8e7c36911b190c85aa641dc0e Mon Sep 17 00:00:00 2001 From: Felix Wang Date: Mon, 21 Mar 2022 16:55:46 -0700 Subject: [PATCH 20/21] ci: Modify release script to only do minor release for breaking changes (#2431) Signed-off-by: Felix Wang Signed-off-by: Tomas Pereira de Vasconcelos From 6c36f690cbb03a9fa69e02b6b67b708260d0ffca Mon Sep 17 00:00:00 2001 From: Achal Shah Date: Mon, 21 Mar 2022 23:31:01 -0700 Subject: [PATCH 21/21] fix: Ensure that __init__ files exist in proto dirs (#2433) Signed-off-by: Achal Shah Signed-off-by: Tomas Pereira de Vasconcelos