From 6d582841f39dcf4aa4f8c6422682cfe699def8f7 Mon Sep 17 00:00:00 2001 From: Jay Chung Date: Thu, 22 Aug 2024 11:53:20 +0800 Subject: [PATCH 1/4] ci: fix codecov/codecov-action not work at macos-13 ref: #150 --- .github/workflows/ci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index f1ac901..025ca26 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -121,7 +121,9 @@ jobs: files: ./coverage.xml flags: unittests name: codecov-umbrella - fail_ci_if_error: true + # codecov/codecov-action have some error in macos-13, revert this patch until issue fixed: https://github.com/codecov/codecov-action/issues/1549 + # syntax ref: https://github.com/actions/runner/issues/409#issuecomment-752775072 + fail_ci_if_error: ${{ matrix.os == 'macos-13' && 'true' || 'false' }} verbose: true doc-build: timeout-minutes: 15 From b88a96f05eee6cfb3ccca5dcec21a3f1d4450aa4 Mon Sep 17 00:00:00 2001 From: Jay Chung Date: Thu, 22 Aug 2024 12:00:00 +0800 Subject: [PATCH 2/4] reverse logic --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 025ca26..2eb311e 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -123,7 +123,7 @@ jobs: name: codecov-umbrella # codecov/codecov-action have some error in macos-13, revert this patch until issue fixed: https://github.com/codecov/codecov-action/issues/1549 # syntax ref: https://github.com/actions/runner/issues/409#issuecomment-752775072 - fail_ci_if_error: ${{ matrix.os == 'macos-13' && 'true' || 'false' }} + fail_ci_if_error: ${{ matrix.os != 'macos-13' && 'true' || 'false' }} verbose: true doc-build: timeout-minutes: 15 From 22887b9f7b4037c2964cc4e88be9708913f5fd25 Mon Sep 17 00:00:00 2001 From: Jay Chung Date: Thu, 22 Aug 2024 12:05:20 +0800 Subject: [PATCH 3/4] ci --- .github/workflows/ci.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2eb311e..3314650 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -111,19 +111,19 @@ jobs: run: | python -m tox -vv -e code-test - uses: codecov/codecov-action@v3 - # Codecov have a 100-upload limit per commit, and there are 3 * 6 files upload each time run pytest, + # FOR NO SCHEDULE: Codecov have a 100-upload limit per commit, and there are 3 * 6 files upload each time run pytest, # We should not run upload in schedule GitHub event, because the sixth day we do not change our code # and the upload limit will be reached 3 * 6 * 6. For more detail can see: # https://community.codecov.com/t/ci-failure-due-to-too-many-uploads-to-this-commit/2587/7 - if: ${{ github.event_name != 'schedule' }} + # FOR NO macos-13: codecov/codecov-action have some error in macos-13, revert this patch until issue + # fixed: https://github.com/codecov/codecov-action/issues/1549 + if: ${{ github.event_name != 'schedule' && matrix.os != 'macos-13' }} with: token: ${{ env.CODECOV_TOKEN }} files: ./coverage.xml flags: unittests name: codecov-umbrella - # codecov/codecov-action have some error in macos-13, revert this patch until issue fixed: https://github.com/codecov/codecov-action/issues/1549 - # syntax ref: https://github.com/actions/runner/issues/409#issuecomment-752775072 - fail_ci_if_error: ${{ matrix.os != 'macos-13' && 'true' || 'false' }} + fail_ci_if_error: true verbose: true doc-build: timeout-minutes: 15 From 3995d0b7324eb0b184254abfb6ec99af1f040f05 Mon Sep 17 00:00:00 2001 From: Jay Chung Date: Thu, 22 Aug 2024 12:08:30 +0800 Subject: [PATCH 4/4] keep name showed in action with same order --- .github/workflows/ci.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3314650..0f74fdf 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -94,10 +94,10 @@ jobs: - os: macos-latest python-version: 3.8 include: - - os: macos-13 - python-version: 3.9 - - os: macos-13 - python-version: 3.8 + - python-version: 3.9 + os: macos-13 + - python-version: 3.8 + os: macos-13 steps: - uses: actions/checkout@v3 - name: Set up Python ${{ matrix.python-version }}